Repository navigation
Conversation
stonebuzz
requested changes
Aug 24, 2026
Rom1-B
force-pushed
the
support_45901
branch
from
September 14, 2026 13:35
a00e318 to
3eb87f1
Compare
Rom1-B
force-pushed
the
support_45901
branch
2 times, most recently
from
September 22, 2026 11:17
96320bf to
1f9fcbe
Compare
RomainLvr
requested changes
Sep 25, 2026
RomainLvr
approved these changes
Sep 28, 2026
stonebuzz
requested changes
Sep 29, 2026
Rom1-B
force-pushed
the
support_45901
branch
from
September 30, 2026 06:11
505470f to
bd5fca3
Compare
stonebuzz
requested changes
Oct 1, 2026
Contributor
|
@Rom1-B can you rebase ? |
Contributor
|
CI failed |
Rom1-B
force-pushed
the
support_45901
branch
2 times, most recently
from
October 12, 2026 09:54
4d0beaa to
9026f8a
Compare
Rom1-B
force-pushed
the
support_45901
branch
2 times, most recently
from
October 14, 2026 12:49
57ea76d to
d2a0ec0
Compare
MyvTsv
reviewed
Oct 20, 2026
MyvTsv
left a comment
MyvTsv
left a comment
Contributor
There was a problem hiding this comment.
I think the user should not be able to reactivate a container that has been inactive for too long, in order to avoid potential errors caused by its reactivation.
MyvTsv
approved these changes
Oct 20, 2026
4 tasks done
stonebuzz
requested changes
Oct 22, 2026
Comment on lines
+1096
to
+1102
| $toolbox = new PluginFieldsToolbox(); | ||
| $new_name = $toolbox->getSystemNameFromLabel($new_name); | ||
| if ($new_name === '') { | ||
| Session::AddMessageAfterRedirect(__('Invalid name.', 'fields'), false, ERROR); | ||
|
|
||
| return false; | ||
| } |
Contributor
There was a problem hiding this comment.
PluginFieldsToolbox::getSystemNameFromLabel() never returns an empty string: for an empty or non-alphanumeric label it falls back to random_int() converted to letters. Submitting the rename form with a blank field therefore renames the container to a random string and reactivates it, and this guard is dead code. Validate the raw input before transforming it.
if (trim($new_name) === '') {
Session::AddMessageAfterRedirect(__('Invalid name.', 'fields'), false, ERROR);
return false;
}
$new_name = $toolbox->getSystemNameFromLabel($new_name);
Lainow
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
plugins:fields:check_databasenow also reports container/item type pairs with no matching table, and tables with no matching container/item type pair.Screenshots (if appropriate):